Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify ws-daemon #18690

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Simplify ws-daemon #18690

merged 1 commit into from
Sep 11, 2023

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Sep 9, 2023

Description

Summary generated by Copilot

🤖 Generated by Copilot at 2db6743

This pull request refactors the code for finding the container's root filesystem in ws-daemon. It removes unnecessary dependencies and simplifies the logic by using a fixed path format based on the containerd ID.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

Gitpod was successfully deployed to your preview environment.

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=workspace
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@roboquat roboquat merged commit cd7dc44 into main Sep 11, 2023
@roboquat roboquat deleted the aledbf/clean-ws-daemon branch September 11, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants