Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[authorization] Extend metric gitpod_guard_access_checks_total by "function-access" #18928

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

geropl
Copy link
Member

@geropl geropl commented Oct 16, 2023

Description

In preparation of EXP-438

Summary generated by Copilot

🤖 Generated by Copilot at f1f6155

This pull request adds a new metric for tracking function access checks by user roles. It modifies the ExplicitFunctionAccessGuard class and the prometheus-metrics module to record and label the guard invocations and outcomes.

Related Issue(s)

Fixes #

How to test

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

@geropl
Copy link
Member Author

geropl commented Oct 16, 2023

/unhold

@roboquat roboquat merged commit 3160a20 into gpl/fga-scopes Oct 16, 2023
32 of 33 checks passed
@roboquat roboquat deleted the gpl/fga-scopes-metric branch October 16, 2023 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants