[authorization] Extend metric gitpod_guard_access_checks_total by "fu…

…nction-access" (#18928)
gitpod-io · Oct 16, 2023 · 3160a20 · 3160a20
1 parent fe087f6
commit 3160a20
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/components/server/src/auth/function-access.ts b/components/server/src/auth/function-access.ts
@@ -5,6 +5,7 @@
  */
 
 import { injectable } from "inversify";
+import { reportGuardAccessCheck } from "../prometheus-metrics";
 
 export interface FunctionAccessGuard {
     canAccess(name: string): boolean;
@@ -28,6 +29,7 @@ export class ExplicitFunctionAccessGuard {
     constructor(protected readonly allowedCalls: string[]) {}
 
     canAccess(name: string): boolean {
+        reportGuardAccessCheck("function-access");
         return this.allowedCalls.some((c) => c === name);
     }
 }
diff --git a/components/server/src/prometheus-metrics.ts b/components/server/src/prometheus-metrics.ts
@@ -348,7 +348,7 @@ export const guardAccessChecksTotal = new prometheusClient.Counter({
     labelNames: ["type"],
 });
 
-export type GuardAccessCheckType = "fga" | "resource-access";
+export type GuardAccessCheckType = "fga" | "resource-access" | "function-access";
 export function reportGuardAccessCheck(type: GuardAccessCheckType) {
     guardAccessChecksTotal.labels(type).inc();
 }