-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧹 Update mocha and remove resolutions #18736
Conversation
update mocha to avoid pulling in [email protected]
New and updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
Will run https://github.com/gitpod-io/gitpod/actions/workflows/lacework-inline-scanner.yml to check the docker images once we got a build. |
Could be that leeway does not like/support custom fields in package.json, which might be the reason we kept the separate config files... will try to figure out in a workspace. |
No, it's just me, trying to remove unnecessary things. I've only tested with leeway and |
Noticed the |
Now we just™️ need to get a green build.
🤷🏻♂️ this doesn't sound like a change caused by this PR. |
Trying to understand the build problem using Can reproduce on this branch. Let's try with Got it! It's the wrong spec selection. On it! |
Triggered scan in https://github.com/gitpod-io/gitpod/actions/runs/6232328813 |
/unhold |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️ 🧹
Description
'Extracted this change from #18734 as it's primarily chores.
This no more:
Summary generated by Copilot
🤖 Generated by Copilot at 295b5d7
This pull request updates and simplifies the mocha test configuration and dependencies for several packages in the gitpod-io/gitpod repository. It also fixes a security issue with
minimatch
and removes unnecessarymocha.opts
files andresolutions
from thepackage.json
files.Related Issue(s)
Fixes #
How to test
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold