Defer stream closure for status observance

gitpod-io · Nov 7, 2023 · ffa3606 · ffa3606
1 parent a24f72d
commit ffa3606
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/components/local-app/cmd/workspace-stop.go b/components/local-app/cmd/workspace-stop.go
@@ -60,6 +60,8 @@ var workspaceStopCommand = &cobra.Command{
 			return err
 		}
 
+		defer stream.Close()
+
 		slog.Info("waiting for workspace to stop...")
 
 		previousStatus := ""

diff --git a/components/local-app/pkg/helper/workspace.go b/components/local-app/pkg/helper/workspace.go
@@ -188,6 +188,8 @@ func ObserveWorkspaceUntilStarted(ctx context.Context, clnt *client.Gitpod, work
 			continue
 		}
 
+		defer stream.Close()
+
 		for stream.Receive() {
 			msg := stream.Msg()
 			if msg == nil {