Skip to content

Commit

Permalink
Enable CRI plugin in dockerd (#18765)
Browse files Browse the repository at this point in the history
  • Loading branch information
aledbf authored Sep 21, 2023
1 parent 6273cc3 commit d7ba4db
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions components/docker-up/docker-up/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
"syscall"
"time"

"github.com/gitpod-io/gitpod/common-go/cgroups"
"github.com/rootless-containers/rootlesskit/pkg/sigproxy"
sigproxysignal "github.com/rootless-containers/rootlesskit/pkg/sigproxy/signal"
"github.com/sirupsen/logrus"
Expand Down Expand Up @@ -104,18 +103,7 @@ func runWithinNetns() (err error) {

args := []string{
"--data-root=/workspace/.docker-root",
}

unified, err := cgroups.IsUnifiedCgroupSetup()
if err != nil {
return xerrors.Errorf("could not determine cgroup setup: %w", err)
}
if !unified {
// Enable rootless mode only in cgroup v1 because docker requires systemd when using it in cgroup v2
args = append(args,
"--experimental",
"--rootless",
)
"--cri-containerd",
}

if opts.Verbose {
Expand Down

0 comments on commit d7ba4db

Please sign in to comment.