-
Notifications
You must be signed in to change notification settings - Fork 60k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update evaluate-expressions-in-workflows-and-actions.md #34369
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
Automatically generated comment ℹ️This comment is automatically generated and will be overwritten every time changes are committed to this branch. The table contains an overview of files in the Content directory changesYou may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.
fpt: Free, Pro, Team |
@dmail Thanks so much for opening a PR! I'll get this triaged for review ✨ |
Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀 |
@dmail Thank you very much for your patience while our SME team reviewed your PR! ✨ Our SME team provided the following feedback on why we are unfortunately unable to accept this PR:
We greatly appreciate your time putting together this PR, and if you have any feedback regarding the response our SME team provided, please let us know! 💛 |
This PR has been automatically closed because there has been no response to to our request for more information from the original author. Please reach out if you have the information we requested, or open a new issue to describing your changes. Then we can begin the review process. |
Why:
I want to have a dynamic path depending on
runner.os
in a GitHub workflow. See microsoft/playwright#7249 for the context.The documentation at https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions helped me. However even with all that documentation it took me a long time to make it work. I would like to add an example to help others that would face a similar use case.
Closes: Nothing
What's being changed (if available, include any code snippets, screenshots, or gifs):
This pull request add an example where a value is a path dynamic per OS.
This example uses
format
andenv.HOME
to build the path on windows, something as follow:This means something before have to set
env.HOME
which can be achieved like this:I don't know if this should be added to the documentation but if we don't add it people will have trouble to make it work.
I hope you'll find this useful, thank you.
Check off the following:
I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).
data
directory.For content changes, I have completed the self-review checklist.