Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KE2: Extract when expressions #18058

Merged
merged 4 commits into from
Nov 25, 2024
Merged

KE2: Extract when expressions #18058

merged 4 commits into from
Nov 25, 2024

Conversation

tamasvajk
Copy link
Contributor

No description provided.

@tamasvajk
Copy link
Contributor Author

Test failures are expected. These are the failure kinds that we get:

-#    7|                           0: [BooleanLiteral] true
+#    7|                           0: [WhenBranchConditionWithExpression] ... ->
+#    7|                             0: [BooleanLiteral] true
...
+| TestKt.kt:497:13:503:13 | ... -> | WhenBranchConditionWithExpression | unexpected dead end |
##[error][6476/11383 comp 26.7s eval 1.7s] FAILED(RESULT) /home/runner/work/semmle-code/semmle-code/ql/java/ql/test/library-tests/pathsanitizer/CONSISTENCY/cfgDeadEnds.ql

@tamasvajk tamasvajk marked this pull request as ready for review November 22, 2024 12:41
@tamasvajk tamasvajk requested review from a team as code owners November 22, 2024 12:41
igfoo
igfoo reviewed Nov 22, 2024
View reviewed changes
java/kotlin-extractor2/src/main/kotlin/entities/Expression.kt Outdated Show resolved Hide resolved
java/kotlin-extractor2/src/main/kotlin/entities/Expression.kt Outdated Show resolved Hide resolved
java/kotlin-extractor2/src/main/kotlin/entities/Expression.kt Outdated Show resolved Hide resolved
java/ql/lib/semmle/code/java/Expr.qll Outdated Show resolved Hide resolved
java/ql/lib/semmle/code/java/Expr.qll Outdated Show resolved Hide resolved
java/ql/lib/semmle/code/java/Expr.qll Show resolved Hide resolved
java/ql/lib/semmle/code/java/Expr.qll Outdated Show resolved Hide resolved
java/ql/lib/semmle/code/java/Expr.qll Outdated Show resolved Hide resolved
@tamasvajk tamasvajk merged commit 0103711 into github:ke2 Nov 25, 2024
3 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igfoo igfoo igfoo approved these changes

Assignees
No one assigned
Labels
Java Kotlin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tamasvajk @igfoo