-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update gem homepage #3
Update gem homepage #3
Conversation
Landed here with the same question. As noted by @hogelog, RubyGems.org links to github/graphql-client via the published gem's metadata. Confused by that, I started digging around and found @rmosolgo had pushed the latest v0.19.0. That led me to rmosolgo/graphql-client which does have a v0.19.0 tag but is also a fork of this project (github-community-projects/graphql-client). rmosolgo/graphql-client and github-community-projects/graphql-client appear to be at parity at the moment, but between the three repositories, it's entirely unclear which is currently the official source for the published gem. A proposal:
Maybe these steps are in the works? Maybe this PR makes them (mostly) unnecessary? Either way, I wanted to share my experience and confusion. Thanks for reading! |
Hey, thanks for taking a look @hogelog and @jgarber623. It's a bit hard to get a read on what's going on inside GitHub right now, but my understanding is:
Sorry for the confusion! I wanted to finally get this gem fixed for graphql-ruby 2.1.0 but maybe I shouldve taken it a bit slower 😅 |
I just went to double-check about tags; it looks like there's a tag here: https://github.com/github-community-projects/graphql-client/releases/tag/v0.19.0 But not one on |
@rmosolgo Thanks for the updates and clarifications! Tangential to this PR: This may or may not suit this project's needs (or your personal preferences), but have you considered setting up GitHub Actions and RubyGem's Trusted Publishing? I've configured several of my gem to publish via GitHub Actions and with Trusted Publishing whenever I create a new GitHub Release (either via the web UI or with If that sounds interesting, I could PR a thing. If not, no worries! 😄 |
I'm definitely interested -- I went looking at that right after reading your comment. But I haven't set it up before. I'd love to see a PR if you're game to give it a try! |
Thanks for the clear explanation and merge! |
I noticed that https://rubygems.org/gems/graphql-client 0.19.0 has been released but wondered why there is no 0.19.0 code on https://github.com/github/graphql-client.
Has the graphql-client repository moved here? If so, I thought the gem's homepage attribute should be updated.