Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update gem homepage #3

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

hogelog
Copy link
Contributor

@hogelog hogelog commented Jan 25, 2024

I noticed that https://rubygems.org/gems/graphql-client 0.19.0 has been released but wondered why there is no 0.19.0 code on https://github.com/github/graphql-client.

Has the graphql-client repository moved here? If so, I thought the gem's homepage attribute should be updated.

@jgarber623
Copy link
Contributor

Landed here with the same question.

As noted by @hogelog, RubyGems.org links to github/graphql-client via the published gem's metadata. Confused by that, I started digging around and found @rmosolgo had pushed the latest v0.19.0. That led me to rmosolgo/graphql-client which does have a v0.19.0 tag but is also a fork of this project (github-community-projects/graphql-client).

rmosolgo/graphql-client and github-community-projects/graphql-client appear to be at parity at the moment, but between the three repositories, it's entirely unclear which is currently the official source for the published gem.

A proposal:

  1. Pick an official source repository (Maybe it's this one? I have no opinion here!)
  2. Update the published gem's metadata to includes links to that repository
  3. Update the other repositories (in the "About" section in the sidebar, maybe?) directing folks to the official source repository
  4. Update the README in github/graphql-client to link to the new official source repository (wherever it is) and archive that repository (assuming github/graphql-client is no longer maintained)

Maybe these steps are in the works? Maybe this PR makes them (mostly) unnecessary? Either way, I wanted to share my experience and confusion. Thanks for reading!

@rmosolgo
Copy link
Collaborator

Hey, thanks for taking a look @hogelog and @jgarber623. It's a bit hard to get a read on what's going on inside GitHub right now, but my understanding is:

  • github/graphql-client is done; we shouldn't expect any more updates there. I honestly don't even know if they'll mark the project as archived.
  • rmosolgo/graphql-client should be my personal fork. I released 0.19.0 from my local environment so I probably pushed the tag to the wrong repo -- I'll take a look at my configuration today and make sure that future releases end up in the right place. Thanks for pointing that out.
  • This repo will be the main repository now -- so updating the gemspec is the right thing 👍

Sorry for the confusion! I wanted to finally get this gem fixed for graphql-ruby 2.1.0 but maybe I shouldve taken it a bit slower 😅

@rmosolgo rmosolgo merged commit a518a47 into github-community-projects:master Jan 25, 2024
21 checks passed
@rmosolgo
Copy link
Collaborator

I just went to double-check about tags; it looks like there's a tag here: https://github.com/github-community-projects/graphql-client/releases/tag/v0.19.0 But not one on rmosolgo/graphql-client (https://github.com/rmosolgo/graphql-client/tags), so I think we're alright there 👍

@jgarber623
Copy link
Contributor

@rmosolgo Thanks for the updates and clarifications!

Tangential to this PR:

This may or may not suit this project's needs (or your personal preferences), but have you considered setting up GitHub Actions and RubyGem's Trusted Publishing?

I've configured several of my gem to publish via GitHub Actions and with Trusted Publishing whenever I create a new GitHub Release (either via the web UI or with gh release create v0.1.0 --generate-notes).

If that sounds interesting, I could PR a thing. If not, no worries! 😄

@rmosolgo
Copy link
Collaborator

I'm definitely interested -- I went looking at that right after reading your comment. But I haven't set it up before. I'd love to see a PR if you're game to give it a try!

@hogelog hogelog deleted the update-homepage branch January 26, 2024 02:31
@hogelog
Copy link
Contributor Author

hogelog commented Jan 26, 2024

Thanks for the clear explanation and merge!
I also appreciate the ongoing development 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants