Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken error links. #11

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Conversation

mikdiet
Copy link
Contributor

@mikdiet mikdiet commented Feb 6, 2024

https://git.io/??? links redirect to old repo name in github organisation.

This patch updates them with direct links on docs in the new repo.

It's just an example of the issue (you don't have issues tab on your repo, otherwise I'd just submitted issue, not code change), I think there's more broken links + tests + you probably want to keep them shortened (and git.io doesn't accept new links).

@rmosolgo
Copy link
Collaborator

rmosolgo commented Feb 8, 2024

Derp, I didn't realize there wasn't an issues tab. I just enabled it!

Anyways, I think this is definitely the right change. Would you mind updating the other references to git.io?

@mikdiet
Copy link
Contributor Author

mikdiet commented Feb 8, 2024

All right, I'll update the rest + tests by direct links.

https://git.io/xxx links redirect to old repo name in `github` organisation.
@mikdiet
Copy link
Contributor Author

mikdiet commented Feb 9, 2024

@rmosolgo updated

@rmosolgo
Copy link
Collaborator

rmosolgo commented Feb 9, 2024

Thank you!

@rmosolgo rmosolgo merged commit 980e2fa into github-community-projects:master Feb 9, 2024
81 checks passed
@mikdiet mikdiet deleted the patch-1 branch February 9, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants