Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable LLDP on Server VMs #289

Merged
merged 2 commits into from
Jan 7, 2025
Merged

Enable LLDP on Server VMs #289

merged 2 commits into from
Jan 7, 2025

Conversation

pau-hedgehog
Copy link
Contributor

@pau-hedgehog pau-hedgehog commented Dec 27, 2024 •
edited
Loading

Enables LLDP on server VM interfaces to cross-check topology:

core@server-1 ~ $ networkctl -l lldp 
LINK   CHASSIS-ID        SYSTEM-NAME CAPS        PORT-ID   PORT-DESCRIPTION                                      
enp2s1 54:bf:64:ba:3d:c0 s5248-01    ....r...... Ethernet1 PC2 MCLAG server-1 server-1--mclag--s5248-01--s5248-02
enp2s2 3c:2c:30:66:f0:00 s5248-02    ....r...... Ethernet1 PC2 MCLAG server-1 server-1--mclag--s5248-01--s5248-02

Capability Flags:
r - Router

2 neighbors listed.

Also enables DHCP on the same interfaces

Frostman
Frostman reviewed Dec 27, 2024
View reviewed changes
hack/tools.just Outdated Show resolved Hide resolved
Frostman
Frostman reviewed Dec 27, 2024
View reviewed changes
hack/tools.just Outdated Show resolved Hide resolved
Frostman
Frostman requested changes Dec 27, 2024
View reviewed changes
pkg/hhfab/vlab_butane.tmpl.yaml Outdated Show resolved Hide resolved
pkg/hhfab/vlab_butane.tmpl.yaml Outdated Show resolved Hide resolved
pkg/hhfab/vlab_butane.tmpl.yaml Outdated Show resolved Hide resolved
pkg/hhfab/vlab_butane.tmpl.yaml Outdated Show resolved Hide resolved
pkg/hhfab/vlab_butane.tmpl.yaml Outdated Show resolved Hide resolved
@pau-hedgehog pau-hedgehog changed the title Server lldp and control vm installation error handling Enable LLDP on Server VMs Dec 28, 2024
@pau-hedgehog pau-hedgehog marked this pull request as ready for review December 31, 2024 22:22
@pau-hedgehog pau-hedgehog changed the title Enable LLDP on Server VMs Enable LLDP and DHCP on Server VMs Dec 31, 2024
@pau-hedgehog pau-hedgehog marked this pull request as draft January 2, 2025 20:16
@pau-hedgehog pau-hedgehog self-assigned this Jan 2, 2025
@pau-hedgehog
Configure LLDP on server VMs
184ba92 
The interfaces connected to the Fabric send/receive LLDP PDUs

Signed-off-by: Pau Capdevila <[email protected]>
@pau-hedgehog
Improve network LLDP configuration
912d225 
Polish systemd-networkd config as proposed by Sergei Lukianov

Signed-off-by: Pau Capdevila <[email protected]>
@pau-hedgehog pau-hedgehog marked this pull request as ready for review January 7, 2025 15:38
@pau-hedgehog pau-hedgehog requested a review from Frostman January 7, 2025 16:03
@Frostman Frostman changed the title Enable LLDP and DHCP on Server VMs Enable LLDP on Server VMs Jan 7, 2025
@Frostman Frostman merged commit 0b08b37 into master Jan 7, 2025
26 checks passed
@Frostman Frostman deleted the server_lldp branch January 7, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frostman Frostman Frostman approved these changes

Assignees

@pau-hedgehog pau-hedgehog

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pau-hedgehog @Frostman