Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Vietnamese team contact #762

Merged
merged 1 commit into from
Apr 28, 2024
Merged

Conversation

Nekosha
Copy link

@Nekosha Nekosha commented Apr 4, 2024

No description provided.

Copy link

github-actions bot commented Apr 4, 2024

Errors and warnings found by git-po-helper in workflow #629:

------------------------------------------------------------------------------
ERROR commit f8a475b: subject ("Update Vietnamese ...") does not have prefix "l10n:" 
------------------------------------------------------------------------------
ERROR commit f8a475b: line #3 ("The previous ...") is too long: 112 > 72 
INFO checking commits: 0 passed, 1 failed.        
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

@jiangxin
Copy link
Member

jiangxin commented Apr 6, 2024

Hi @vnwildman, can you help me approve this pull request from @Nekosha ?

@jiangxin
Copy link
Member

jiangxin commented Apr 6, 2024

Errors and warnings found by git-po-helper in workflow #629:

------------------------------------------------------------------------------
ERROR commit f8a475b: subject ("Update Vietnamese ...") does not have prefix "l10n:" 
------------------------------------------------------------------------------
ERROR commit f8a475b: line #3 ("The previous ...") is too long: 112 > 72 
INFO checking commits: 0 passed, 1 failed.        
------------------------------------------------------------------------------
INFO downloading pot file from https://github.com/git-l10n/pot-changes/raw/pot/master/po/git.pot 

ERROR: fail to execute "git-po-helper check-commits"

@Nekosha , we have a CI system (based on GitHub Actions) to find issues on l10n contributions. Please fix the above issues.

@jiangxin
Copy link
Member

jiangxin commented Apr 17, 2024

In the trailer you leave your signature with an email address unable to reach:

Signed-off-by: Nekosha <[email protected]>

How about using your email address or signature in TEAMS file?

Signed-off-by: Vũ Tiến Hưng  <[email protected]>

@vnwildman
Copy link
Member

Hi @vnwildman, can you help me approve this pull request from @Nekosha ?

Hi, @jiangxin, yes, please approve @Nekosha as coordinator of Vietnamese Git translate team.
@Nekosha should use real full name to sign any commit.
Well come @Nekosha joint this team!

@Nekosha
Copy link
Author

Nekosha commented Apr 18, 2024

Thanks, I've fixed the commit message.

@jiangxin
Copy link
Member

Thanks, I've fixed the commit message.

But the author and committer are not fixed. See the meta info of your commit below:

commit 7f2a4fff4eb8e0c50c9ab4e5a1b8dee65cacfa75
Author:     Nekosha <[email protected]>
AuthorDate: 2024-04-04 11:35:20 +0700
Commit:     Nekosha <[email protected]>
CommitDate: 2024-04-18 16:40:09 +0700

    l10n: Update Vietnamese team contact

    The previous team has not maintained the translation since 2.37. Leader
    has agreed to transfer leadership to me.

    Signed-off-by: Vũ Tiến Hưng <[email protected]>

To fix the author and committer of your commit:

  1. Set your name and address properly using:

     git config user.name "Your Name" 
     git config user.email your@email
    
  2. Amend your commit with --reset-author option like:

     git commit -s --reset-author --amend
    

The previous team has not maintained the translation since 2.37. Leader
has agreed to transfer leadership to me.

Signed-off-by: Vũ Tiến Hưng <[email protected]>
@Nekosha
Copy link
Author

Nekosha commented Apr 26, 2024

Fixed the author info.

@jiangxin jiangxin merged commit 7ddd462 into git-l10n:master Apr 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants