Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 로그인한 유저만 buy할 수 있도록 처리 #247

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

sumi-0011
Copy link
Member

@sumi-0011 sumi-0011 commented Dec 11, 2024

Summary by CodeRabbit

  • 신규 기능

    • 구매 기능을 사용하기 위해 로그인 필요성에 대한 메시지를 추가했습니다.
    • 버튼 텍스트가 사용자의 로그인 상태에 따라 변경됩니다.
  • 버그 수정

    • 로그인하지 않은 사용자가 구매를 시도할 경우 오류 메시지를 표시하도록 개선했습니다.

Copy link

coderabbitai bot commented Dec 11, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

이번 변경사항은 애플리케이션의 JSON 로컬라이제이션 파일에 새로운 문자열 항목을 추가합니다. "Shop" 섹션에는 로그인 요구 사항에 대한 사용자 피드백을 강화하기 위해 두 개의 새로운 키가 추가되었습니다. "Background" 섹션에서도 새로운 키가 추가되어 로그인 후 특정 기능을 사용할 수 있도록 사용자에게 안내합니다. 코드의 전반적인 구조는 유지되며, 기존 키나 값의 삭제나 중요한 변경은 없습니다.

Changes

파일 경로 변경 요약
apps/web/messages/en_US.json "Shop" 섹션에 "buy-error-not-login""buy-possible-user" 추가. "Background" 섹션에 "buy-possible-user" 추가.
apps/web/messages/ko_KR.json "Background" 섹션에 "buy-possible-user": "로그인 후 이용해주세요." 추가.
apps/web/src/app/[locale]/event/(common)/BackgroundSection.tsx isLoggedIn 변수 추가 및 BackgroundItem 컴포넌트에 로그인 상태를 전달하여 버튼 텍스트 변경.

Possibly related PRs

  • 상점 페이지 리뉴얼 버그 픽스 - 1 #198: 사용자 로그인 요구 사항과 관련된 새로운 로컬라이제이션 문자열을 추가하는 주요 PR로, PR #198에서 다루는 상점 페이지 갱신과 관련이 있을 수 있습니다.

Suggested labels

diff: M

Suggested reviewers

  • hyesungoh

Poem

🐇 로그인 후에만,
구매할 수 있어요,
메시지로 알려줘,
우리 함께 하죠!
즐거운 쇼핑길,
로그인 잊지 말고,
행복한 하루 되세요! 🌟


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 1c33393 and 038ca2a.

📒 Files selected for processing (3)
  • apps/web/messages/en_US.json (1 hunks)
  • apps/web/messages/ko_KR.json (1 hunks)
  • apps/web/src/app/[locale]/event/(common)/BackgroundSection.tsx (5 hunks)

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sumi-0011 sumi-0011 merged commit d171bd3 into main Dec 11, 2024
2 checks passed
@sumi-0011 sumi-0011 deleted the fix/event-login-buy branch December 11, 2024 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant