installer: skip Experimental Options page, if empty #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rimrul
approved these changes
Oct 28, 2024
installer/install.iss
Outdated
| @@ -423,6 +423,7 @@ const | |||
| GP_BuiltinAddI = 4; | |||
| GP_EnablePCon = 5; | |||
| GP_EnableFSMonitor = 6; | |||
| GP_Max = 6; | |||
There was a problem hiding this comment.
This is a great idea, but the name is slightly confusing since we use the same GP_ prefix for other things.
There was a problem hiding this comment.
I revamped this rather completely. Could you have another look, @rimrul?
Signed-off-by: Johannes Schindelin <[email protected]>
For drop-down and radio button options, we used to manually pick the largest value when defining the size of the corresponding array. Let's instead introduce consistent `..._Max...` constants for this purpose. This will make the next commit cleaner, where we need to iterate over all experimental options. Signed-off-by: Johannes Schindelin <[email protected]>
As of a75602a (installer: hide the "experimental" FSMonitor setting by default, 2024-07-17), the FSMonitor option is hidden from the options page unless the user had enabled it previously. However, this then left the page blank (or: all options hidden), not a good user experience. So let's skip it if it would appear blank. This fixes git-for-windows/git#5231. Signed-off-by: Johannes Schindelin <[email protected]>
…xperimental option If all of the experimental options are hidden, we skip that page. However, this is the last page of the wizard (at least if there are no active processes that would block the installation), and that is therefore the page where we re-label the "Next" button so that it says "Install". Therefore, if the experimental options page is hidden, we need to move that button re-labeling to the preceding page. Signed-off-by: Johannes Schindelin <[email protected]>
dscho
force-pushed
the
avoid-empty-experimental-options-page
branch
from
70911c3
to
18e1a8d
Compare
mjcheetham
approved these changes
Nov 5, 2024
|
/add relnote bug Due to a bug introduced in the v2.47 cycle, the installer showed an empty "experimental options" page, which was fixed. The workflow run was started |
github-actions bot
pushed a commit
that referenced
this pull request
Nov 5, 2024
Due to a bug introduced in the v2.47 cycle, [the installer showed an empty "experimental options" page](git-for-windows/git#5231), which was [fixed](#578). Signed-off-by: gitforwindowshelper[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of a75602a (installer: hide the "experimental" FSMonitor setting by default, 2024-07-17), the FSMonitor option is hidden from the options page unless the user had enabled it previously.
However, this then left the page blank (or: all options hidden), not a good user experience. So let's skip it if it would appear blank.
This fixes git-for-windows/git#5231.