Emit event for overlay annotations #787
Conversation
Also fix URL generation for tiled pixelmaps.
| // For pixelmap overlays, there are additional parameters to set | ||
| layerParams.keepLower = false; | ||
| layerParams.url = layerParams.url + `?encoding=PNG`; | ||
| if (levelDifference > 0) { |
There was a problem hiding this comment.
Why is this necessary since if this is non-zero the url would have already been 'api/v1/item/' + overlayImageId + /tiles/zxy/${z - levelDifference}/${x}/${y} based on the code in _generateOverlayLayerParam? The only difference I see is a / before the ?encoding=PNG
There was a problem hiding this comment.
In the case that levelDifference is non-zero, layerParams.url is a function, so concatenating the ?encoding=PNG wasn't working in that case.
Is there a better way to do change the function?
I've recently pushed 14d38de to make sure the levelDifference check passes if it is non-zero, not just positive, and removed those extra / characters from the url.
There was a problem hiding this comment.
Probably we should eventually abstract this to have the GeoJS utility functions generate appropriate urls directly based on the level difference. For now, this is fine.
Previously it only checked for greater than zero, but levelDifference could be negative. Also remove extra / from layer URL.
This PR makes the following changes:
g:drawOverlayAnnotationwhen a GeoJS layer is created for an image overlay. This is useful for code that useslarge_image, such asHistomicsUI, since creating these layers happens asynchronously.pixelmapwould be malformed if it had a different number of zoom levels compared to the base image layer.