-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a getAvailableNamedPalettes function. #741
Conversation
There are a lot of named palettes. With palettable and matplotlib, I get 3380 named palettes excluding individual colors and 4541 including them. |
ooof. that's a lot. Too many if trying to send that over to a drop down menu in a UI Could we separate them into a dictionary? E.g, {
'matplotlib': ['...', ...],
'palettable': ['...', ...],
'colors': ['...', ...],
...
} |
A large number of the variations come from (a) palettable having distinct names for each variant with a different number of points in the lookup table (e.g., I think a better choice might be to add a |
I pushed a change adding the |
Lastly, in the reduced set of palettes, there are some function duplicates: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think shortening the way you did is a good implementation and this PR is good to merge.
Downstream, we may just create this list ourselves in RGD. I'm not huge on palettable and I think we'll just stick with MPL's full set (along with cmocean's as well) as the reversed maps are very useful
Closes #731.