Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to turn off BIGTIFF #590

Closed
wants to merge 5 commits into from
Closed

Add option to turn off BIGTIFF #590

wants to merge 5 commits into from

Conversation

banesullivan
Copy link
Contributor

Adds a way to control the COG conversion utility's output and turn off the default BIGTIFF option

@manthey
Copy link
Member

manthey commented Apr 13, 2021

There is a IF_NEEDED value for the BIGTIFF option that we should use instead.

@manthey
Copy link
Member

manthey commented Apr 13, 2021

Actually, the GDAL docs say:

  -  IF_NEEDED will only create a BigTIFF if it is clearly needed (in
      the uncompressed case, and image larger than 4GB. So no effect
      when using a compression).
   -  IF_SAFER will create BigTIFF if the resulting file \*might\*
      exceed 4GB. Note: this is only a heuristics that might not always
      work depending on compression ratios.

Neither are guaranteed. Looking at the code, IF_SAFER checks if the uncompressed image is > 2GB regardless of compression. IF_NEEDED only if the uncompressed image is > 4GB AND uncompressed. So IF_SAFER will probably mostly be sufficient as the default, and then we can allow the values to be overridden as in this PR.

@manthey
Copy link
Member

manthey commented Apr 20, 2021

#594 is going to cause this PR to need to be refactored. It also will switch the default to IF_SAFER, which might be sufficient for most use cases.

@manthey
Copy link
Member

manthey commented May 24, 2021

I'm going to close this, as I think the changes in #594 obviated the need for it. Please reopen if you think it is still necessary.

@manthey manthey closed this May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants