Refactor image conversion task. #518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This splits the conversion process so that it is separate from the Girder worker task. The new packages are now in the utilities directory. It adds explicit support for processing geotiffs. It adds support for reprocessing files that could be read by large image, making them a more preferred format for reading tiles. There are now options for lossless or lossy compression, plus more options for compression techniques. By default, if a file is not known to be compressed in a lossy manner, the resulting converted file will be lossless. The converter doesn't use subprocess (it uses the python interfaces for vips and GDAL); this keeps the memory footprint smaller. This is part of a series of PRs refactoring conversion. Future PRs will add support for multi-frame images, for converting files that can be read with large image but not by vips or gdal, and for adding jp2k tile support.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the conversion process so that it is separate from the Girder worker task. The new packages are now in the utilities directory.
It adds explicit support for processing geotiffs. It adds support for reprocessing files that could be read by large image, making them a more preferred format for reading tiles.
There are now options for lossless or lossy compression, plus more options for compression techniques. By default, if a file is not known to be compressed in a lossy manner, the resulting converted file will be lossless.
The converter doesn't use subprocess (it uses the python interfaces for vips and GDAL); this keeps the memory footprint smaller.
This is part of a series of PRs refactoring conversion. Future PRs will add support for multi-frame images, for converting files that can be read with large image but not by vips or gdal, and for adding jp2k tile support.
Closes #400.