Harden updating the item view after making a large image. #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is one of the causes of transient test failures, but shows a user interface bug. Occasionally, when making a large image that requires converting via a job, the page would update after the job completed but before the image was marked as updated. This would result in the page refreshing and still showing that the job was pending. This substantially reduces transient test failures in one test environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of the causes of transient test failures, but shows a user interface bug. Occasionally, when making a large image that requires converting via a job, the page would update after the job completed but before the image was marked as updated. This would result in the page refreshing and still showing that the job was pending.
This substantially reduces transient test failures in one test environment.