Work around a file descriptor issue in cheroot. #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is an issue that was introduced in 8.1.0 that throws an error when file descriptor numbers are large (see cherrypy/cheroot#249). We can't pin cheroot to an older version, as that breaks support for modern python versions. It isn't clear if limiting the size of our cache will really help -- the cheroot issue implies that it is leaking file descriptors, so this may not do anything useful.
dgutman
approved these changes
Jul 13, 2020
|
system stable since patch |
dgutman
approved these changes
Jul 13, 2020
|
Looks like the issue is resolved on cheroot: cherrypy/cheroot#249 (comment) |
|
Once cherrypy/cheroot#301 is merged and in a version on pypi, I'll revert this commit. |
|
Hi @manthey. They have released the new version: https://pypi.org/project/cheroot/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue that was introduced in 8.1.0 that throws an error when file descriptor numbers are large (see cherrypy/cheroot#249). We can't pin cheroot to an older version, as that breaks support for modern python versions.