Do a migration of database values on start. #431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
force-pushed
the
database-migration
branch
from
d689aa5 to
6cad8f7
Compare
We were doing on-demand migrations to have ACLs and groups in annotation models, since originally we didn't have these. Not having them prevents certain optimizations, like getting count of total number of annotations as a header when listing annotations. Although there could be a slow one-time response to this, and, without appropriate indices, the initial start-up will be slower, the benefits outweigh this cost. As a benefit of this, for instance, the query to display the number of annotations in the image list can return much less data, since it can get the number of annotations from the header.
manthey
force-pushed
the
database-migration
branch
from
6cad8f7 to
22a6ecc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were doing on-demand migrations to have ACLs and groups in annotation models, since originally we didn't have these. Not having them prevents certain optimizations, like getting count of total number of annotations as a header when listing annotations. Although there could be a slow one-time response to this, and, without appropriate indices, the initial start-up will be slower, the benefits outweigh this cost.
As a benefit of this, for instance, the query to display the number of annotations in the image list can return much less data, since it can get the number of annotations from the header.