Fix an issue with annotation permissions. #428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user or group has been removed from the system such that it still exists in an access control list, when the access list is read, Girder prunes the missing users and groups and writes back the access list. However, for annotations, this could cause a save with an empty array of elements, effectively removing the elements from the annotation. This, instead, updates the annotation's access list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user or group has been removed from the system such that it still exists in an access control list, when the access list is read, Girder prunes the missing users and groups and writes back the access list.
However, for annotations, this could cause a save with an empty array of elements, effectively removing the elements from the annotation. This, instead, updates the annotation's access list.