Setting global config file based on settings #1649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readjust how group access level parameters are applied and document why.
I think it needs to be on the |
manthey
reviewed
Sep 25, 2024
| # Do this after merging groups, because the group access-level values can | ||
| # override the base access-level options. For instance, if the base has | ||
| # an admin option, and the group has a user option, then doing this before | ||
| # group application can end up with user options for an admin. |
There was a problem hiding this comment.
@jeffbaumes Note the rationale here -- now documented.
manthey
force-pushed
the
settings-to-config-file
branch
from
ae1d406 to
f2facdb
Compare
This has to be done when checking if we can read or write the folder.
manthey
force-pushed
the
settings-to-config-file
branch
from
89c6654 to
9432239
Compare
manthey
approved these changes
Sep 25, 2024
|
I updated to incorporate your changes and everything seems to be working as intended with some in-progress config-changing UI. |
manthey
added a commit
that referenced
this pull request
Sep 26, 2024
With the addition of #1649, we always use the large_image itemList rather than modifying the base girder item list. We no longer need the code that did that modification. Don't display column titles on an empty list. Make check boxes easier to click. Allow long strings to break more efficiently.
manthey
added a commit
that referenced
this pull request
Sep 26, 2024
With the addition of #1649, we always use the large_image itemList rather than modifying the base girder item list. We no longer need the code that did that modification. Don't display column titles on an empty list. Make check boxes easier to click. Allow long strings to break more efficiently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The table view is now always active because there is always a config file, which is built from the legacy settings if no actual config file exists in the folder hierarchy.
There is now also a place to store user-specific settings, which override group settings, which override general access level settings, which override top-level settings.
@manthey Note that even though you suggested creating the file with
force=bool(user_context), this is not an option when creating a file so that is currently not in there.