Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multisource dtype bugs #1520

Merged
merged 1 commit into from
May 10, 2024
Merged

Fix multisource dtype bugs #1520

merged 1 commit into from
May 10, 2024

Conversation

willdunklin
Copy link
Contributor

@willdunklin willdunklin commented May 7, 2024

Made sure that _addSourceToTile's sourceTile is being cast to the proper dtype for the tilesource. Previously all sourceTiles defaulted to float32 which caused certain issues with compositing (and contributed to the bug below).

Removed self.dtype references from _mergeTiles in lieu of the appropriate types recovered from the sourceTile changes. Using self.dtype here was causing issues for edge cases with alpha compositing. In TileSource.dtype, the _dtype value is set to 'check' temporarily to let the code sample a tile with getRegion (which typically needs a temp value for metadata checks); however, with MultiFileTileSource, the dtype was needed for getRegion sampling in a meaningful capacity (here with the fullAlphaValue calls) so a dtype = 'check' caused certain edge cases to crash.

@willdunklin willdunklin requested a review from manthey May 7, 2024 19:57
@manthey manthey merged commit d8adabb into master May 10, 2024
16 checks passed
@manthey manthey deleted the multi-source-dtype-fix branch May 10, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants