Fix histogram request bug in band compositing mode #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annehaley
force-pushed
the
composites-histogram-reqs
branch
from
ac81c79 to
7c90a8b
Compare
manthey
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1458.
After viewing the histograms in channel compositing mode, those histogram components still exist after switching to band compositing mode. The instances for the channel compositing table are invisible, but still send requests with a
framedeltaevery time thecurrentFramechanges.This PR prevents sending histogram requests while the parent compositing table of the histogram component is not active.
One additional change enables band compositing on images with greater than 4 bands without assigned names; default names are assigned.