Default to "None" for the limit #1359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think with this change, we have to change line https://github.com/girder/large_image/blame/master/sources/dicom/test_dicom/web_client_specs/dicomWebSpec.js#L115 back to |
On the master branch, if I try to import with no limit set, I get the following error: ``` Invalid value for integer parameter limit: . ``` We should remove the datatype restriction and set the default to `None`. That way, it will work properly. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
limit-default-none
branch
from
42735f2 to
2a2d355
Compare
Done. Looks like the CI is passing now. |
manthey
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the master branch, if I try to import with no limit set, I get the following error:
We should remove the datatype restriction and set the default to
None. That way, it will work properly.