Add token authentication option for DICOMweb #1349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psavery
force-pushed
the
token-authentication
branch
2 times, most recently
from
3b51045 to
9b1d9e8
Compare
|
I converted this back to a draft because I realized we are not actually passing this token-containing session to However, |
psavery
force-pushed
the
token-authentication
branch
from
9b1d9e8 to
7f0856a
Compare
|
This now works again, but it depends on imi-bigpicture/wsidicom#117 |
psavery
added a commit
to psavery/large_image
that referenced
this pull request
Nov 13, 2023
As of the latest `wsidicom` release (0.13.0), the new `__init__` method just takes a `requests.Session` object. The old `__init__` method was moved to the class method `create_client()`. So we need to update the way we initialize it. In girder#1349, we are adding authentication where we create the DICOMwebClient object ourselves, so go ahead and do that now to simplify that one. Signed-off-by: Patrick Avery <[email protected]>
psavery
added a commit
to psavery/large_image
that referenced
this pull request
Nov 13, 2023
As of the latest `wsidicom` release (0.13.0), the new `__init__` method just takes a `DICOMwebClient` object. The old `__init__` method was moved to the class method `create_client()`. So we need to update the way we initialize it. In girder#1349, we are adding authentication where we create the DICOMwebClient object ourselves, so go ahead and do that now to simplify that one. Signed-off-by: Patrick Avery <[email protected]>
psavery
added a commit
to psavery/large_image
that referenced
this pull request
Nov 13, 2023
As of the latest `wsidicom` release (0.13.0), the new `__init__` method just takes a `DICOMwebClient` object. The old `__init__` method was moved to the class method `create_client()`. So we need to update the way we initialize it. In girder#1349, we are adding authentication where we create the DICOMwebClient object ourselves, so go ahead and do that now to simplify that one. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
token-authentication
branch
from
9d91994 to
e6df8d8
Compare
When the user is creating a DICOMweb assetstore, if they select the "token" authentication type, an input box will appear where the user must enter the token. This token is saved in MongoDB, and is used for making all requests for this DICOMweb assetstore. That includes requests for importing the data (which may only be done by an admin), and requests for viewing the data (which may be done by anyone with access to the folder). If an admin wishes to restrict users from viewing DICOMweb assets that were imported using this token, the admin must restrict access to the imported items via girder's folder access controls. Signed-off-by: Patrick Avery <[email protected]>
This is what it was before... Signed-off-by: Patrick Avery <[email protected]>
The `WsiDicomWebClient` class now takes a `DICOMwebClient` object as its argument. Update our instantiation to reflect this. Signed-off-by: Patrick Avery <[email protected]>
psavery
force-pushed
the
token-authentication
branch
from
e6df8d8 to
6f165e1
Compare
Signed-off-by: Patrick Avery <[email protected]>
manthey
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the user is creating a DICOMweb assetstore, if they select the "token" authentication type, an input box will appear where the user must enter the token.
This token is saved in MongoDB, and is used for making all requests for this DICOMweb assetstore. That includes requests for importing the data (which may only be done by an admin), and requests for viewing the data (which may be done by anyone with access to the folder).
If an admin wishes to restrict users from viewing DICOMweb assets that were imported using this token, the admin must restrict access to the imported items via girder's folder access controls.
Fixes: #1313
Depends on: imi-bigpicture/wsidicom#117