Add hidden divs for frame_id and frame_styling #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manthey
reviewed
May 1, 2023
| @@ -135,6 +137,8 @@ export default Vue.extend({ | |||
|
|
|||
| <template> | |||
| <div class="image-frame-control-box"> | |||
| <div id="frame_id" style="display: none;">{{ currentFrame }}</div> | |||
There was a problem hiding this comment.
I'd like to propose different element IDs for these: current_image_frame and current_image_style.
Update invisible field ids
|
In trying this out, I realize that in slicer_cli_web's code, we had imagined that we would be getting the value of an input control rather than the contained text of a div. That could be changed and then this will work as is. |
manthey
approved these changes
May 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1124