Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a frames property to the tile source #1014

Merged
merged 1 commit into from
Dec 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,13 @@
# Change Log

## 1.18.1
## 1.19.0

### Features
- Add a frames property to the tile source as a short hand for getting the number of frames from the metadata ([#1014](../../pull/1014))

### Improvements
- Better release file handles ([#1007](../../pull/1007))
- Support tiny images from the test source ([#1011](../../pull/1011))
- Support tiny images from the test source ([#1013](../../pull/1013))

### Changes
- Don't report filename in internal PIL metadata ([#1006](../../pull/1006))
Expand Down
7 changes: 7 additions & 0 deletions large_image/tilesource/base.py
Original file line number Diff line number Diff line change
Expand Up @@ -2572,6 +2572,13 @@ def getPixel(self, includeTileRecord=False, **kwargs):
pixel.update(dict(zip([img.mode.lower()], [img.load()[0, 0]])))
return pixel

@property
def frames(self):
"""A property with the number of frames."""
if not hasattr(self, '_frameCount'):
self._frameCount = len(self.getMetadata().get('frames', [])) or 1
return self._frameCount


class FileTileSource(TileSource):

Expand Down
8 changes: 4 additions & 4 deletions sources/nd2/large_image_source_nd2/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,7 @@ def __init__(self, path, **kwargs):
self.levels = int(max(1, math.ceil(math.log(
float(max(self.sizeX, self.sizeY)) / self.tileWidth) / math.log(2)) + 1))
try:
self._framecount = (
self._frameCount = (
self._nd2.metadata.contents.channelCount * self._nd2.metadata.contents.frameCount)
except Exception:
self._nd2.close()
Expand Down Expand Up @@ -224,7 +224,7 @@ def getMetadata(self):
axes = self._nd2order[:self._nd2order.index('Y')][::-1]
sizes = self._nd2.sizes
result['frames'] = frames = []
for idx in range(self._framecount):
for idx in range(self._frameCount):
frame = {'Frame': idx}
basis = 1
ref = {}
Expand Down Expand Up @@ -265,10 +265,10 @@ def getInternalMetadata(self, **kwargs):
@methodcache()
def getTile(self, x, y, z, pilImageAllowed=False, numpyAllowed=False, **kwargs):
frame = self._getFrame(**kwargs)
self._xyzInRange(x, y, z, frame, self._framecount)
self._xyzInRange(x, y, z, frame, self._frameCount)
x0, y0, x1, y1, step = self._xyzToCorners(x, y, z)
tileframe = self._nd2array
fc = self._framecount
fc = self._frameCount
fp = frame
for axis in self._nd2order[:self._nd2order.index('Y')]:
fc //= self._nd2.sizes[axis]
Expand Down
2 changes: 2 additions & 0 deletions test/test_source_base.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,9 @@ def testSourcesTilesAndMethods(source, filename):
# assert len(ts.histogram()['histogram']) >= 1
# assert ts.histogram(onlyMinMax=True)['min'][0] is not None
# Test multiple frames if they exist
assert ts.frames >= 1
if len(tileMetadata.get('frames', [])) > 1:
assert ts.frames == len(tileMetadata['frames'])
tsf = sourceClass(imagePath, frame=len(tileMetadata['frames']) - 1)
tileMetadata = tsf.getMetadata()
utilities.checkTilesZXY(tsf, tileMetadata)
Expand Down