Mark troublesome encodings with xfail #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #44 +/- ##
=======================================
Coverage 95.58% 95.58%
=======================================
Files 16 16
Lines 679 679
=======================================
Hits 649 649
Misses 30 30 |
banesullivan
commented
Aug 30, 2022
Comment on lines
-38
to
39
| source = self.get_tile_source(request, pk) | ||
| source = self.get_tile_source(request, pk, encoding=encoding) | ||
| thumb_data, mime_type = source.getThumbnail(encoding=encoding, width=width, height=height) |
There was a problem hiding this comment.
@manthey, should we open an image with the same encoding as we are requesting for the thumbnail? Or should this not matter? What do you recommend?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: girder/large_image#950