github: Pouvoir lancer cy.yml sur les PR ouvertes depuis un fork publique
#5324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This seems to be needed so the workflow is triggered when clicking the "Approve and run" button for a pull request opened from a public fork: https://docs.github.com/en/actions/managing-workflow-runs-and-deployments/managing-workflow-runs/approving-workflow-runs-from-public-forks
rsebille
added
the
no-changelog
The workflow will now trigger when a pull request is associated to the branch or when a commit is pushed to `master`.
rsebille
changed the title
cy.yml on pull_request eventscy.yml sur les PR ouvertes depuis un fork publique
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Notre configuration sur le dépôt fait que Github bloque le lancement des workflows pour les nouveaux contributeurs, dans le bloc de fusion [1] il y a alors un bouton "Approve and run" qui permet de lancer le workflow si on fait confiance aux modifications apportées par la PR, mais notre action de CI n'est pas relancée lorsqu'on clique sur ce bouton, ce qui bloque la fusion de la PR.
Je me souviens de discussion à ce propos mais pas retrouver de commit donc j'imagine qu'on repart pour un tour 😅.
push+pull_requestInconvénient : Ouvrir la PR relance le workflow en entier, même si pas de changement depuis.
push: master+pull_requestInconvénient : Oblige d'ouvrir une PR (au moins en draft) pour avoir la CI de lancée.
Cas pratique
#5323
[1]
