Sécurité: correction d'une faille d'injection HTML #5287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
added
the
no-changelog
rsebille
approved these changes
Dec 18, 2024
There was a problem hiding this comment.
Effectivement je sais pas si on veux garder test_xss, il me semble pas que ça avait été fait pour les autres et je pense pas qu'il y aura de régression car je doute que quelqu'un vire le format_html(), il y a plus de chance qu'une XSS soit ajouté a coté que sur ce cas là précis.
calummackervoy
approved these changes
Dec 18, 2024
celine-m-s
approved these changes
Dec 18, 2024
|
Attendre le GO de Charles avant de merger. |
xavfernandez
changed the title
since it is based on assertNotContains it is unlikely that it will break one day
xavfernandez
force-pushed
the
xfernandez/fix_xss
branch
from
267fc58 to
4d40f4d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Pour s'éviter des soucis.
🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran