Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: suppression de la méthode member_required #5268

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

xavfernandez
Copy link
Contributor

🤔 Pourquoi ?

On a déjà l'info via le middleware donc par nécessaire de la re-récupérer une nouvelle fois d'une autre façon.

🍰 Comment ?

Décrivez en quelques mots la solution retenue et mise en oeuvre, les difficultés ou problèmes rencontrés. Attirez l'attention sur les décisions d'architecture ou de conception importantes.

🚨 À vérifier

  • Mettre à jour le CHANGELOG_breaking_changes.md ?

🏝️ Comment tester

Les instructions pour reproduire le problème, les profils de test, le parcours spécifique à utiliser, etc. Si vous disposez d'une recette jetable, mettre l'URL pour tester dans cette partie.

💻 Captures d'écran

@xavfernandez xavfernandez added the no-changelog Ne doit pas figurer dans le journal des changements. label Dec 16, 2024
@xavfernandez xavfernandez self-assigned this Dec 16, 2024
instead of member_required query set method
It avoids an extra query
instead of member_required since we already have the membership info
@xavfernandez xavfernandez force-pushed the xfernandez/drop_member_required branch from 2cedabe to e93d8aa Compare December 16, 2024 12:11
@xavfernandez xavfernandez added this pull request to the merge queue Dec 16, 2024
Merged via the queue into master with commit ccbddb1 Dec 16, 2024
11 checks passed
@xavfernandez xavfernandez deleted the xfernandez/drop_member_required branch December 16, 2024 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Ne doit pas figurer dans le journal des changements.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants