Tech: correction du comportement de member_required
#5267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xavfernandez
added
the
no-changelog
francoisfreitag
approved these changes
Dec 16, 2024
| @@ -16,7 +16,16 @@ class OrganizationQuerySet(models.QuerySet): | |||
| """ | |||
|
|
|||
| def member_required(self, user): | |||
| return self.filter(members=user, members__is_active=True) | |||
| membership_model = self.model.members.through | |||
| # through_fields contains a tuple like ("company", "user") | |||
There was a problem hiding this comment.
Je vois que l’ordre est documenté, peut-être le préciser. 🤷
xavfernandez
force-pushed
the
xfernandez/member_required
branch
from
38e9f7b to
71f521e
Compare
Si c’est raisonnable en terme de taille de dev, ça me semble effectivement mieux. |
xavfernandez
force-pushed
the
xfernandez/member_required
branch
from
71f521e to
6f24fe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 Pourquoi ?
Les Memberships inactives ne devraient pas être prises en compte.
request.organizations, ce qui éviterait des requêtes inutiles et centraliserait la règle métier.🍰 Comment ?
🚨 À vérifier
🏝️ Comment tester
💻 Captures d'écran