job_applications: fix is_active_company_member

to check that the membership is still active

itou/job_applications/models.py

@@ -14,6 +14,7 @@
 from itou.approvals.models import Approval, Suspension
 from itou.approvals.notifications import PassAcceptedEmployerNotification
 from itou.companies.enums import SIAE_WITH_CONVENTION_KINDS, CompanyKind, ContractType
+from itou.companies.models import CompanyMembership
 from itou.eligibility.enums import AuthorKind
 from itou.eligibility.models import EligibilityDiagnosis, SelectedAdministrativeCriteria
 from itou.job_applications.enums import (
@@ -134,7 +135,13 @@ class JobApplicationWorkflow(xwf_models.Workflow):
 
 class JobApplicationQuerySet(models.QuerySet):
     def is_active_company_member(self, user):
-        return self.filter(to_company__members=user, to_company__members__is_active=True)
+        return self.filter(
+            Exists(
+                CompanyMembership.objects.filter(
+                    user=user, is_active=True, user__is_active=True, company=OuterRef("to_company")
+                )
+            )
+        )
 
     def pending(self):
         return self.filter(state__in=JobApplicationWorkflow.PENDING_STATES)

tests/job_applications/tests.py

@@ -166,6 +166,22 @@ def test_inverted_vae_contract(self):
         assert "Un contrat associé à une VAE inversée n'est possible que pour les GEIQ" in str(excinfo.value)
 
 
+class TestJobApplicationQueryset:
+    def test_is_active_company_member(self):
+        job_application = JobApplicationFactory()
+        user = EmployerFactory()
+        assert JobApplication.objects.is_active_company_member(user).count() == 0
+
+        job_application.to_company.add_or_activate_member(user)
+        assert JobApplication.objects.is_active_company_member(user).get() == job_application
+
+        membership = job_application.to_company.memberships.filter(user=user).get()
+        membership.is_active = False
+        membership.save(update_fields=("is_active",))
+
+        assert JobApplication.objects.is_active_company_member(user).count() == 0
+
+
 def test_can_be_cancelled():
     assert JobApplicationFactory().can_be_cancelled is True