refactor: versionning des variables applicatives #857

vincentporte · 2024-12-11T15:45:21Z

Description

🎸 Versionner les variables applicatives de la communauté

Type de changement

🚧 technique

Points d'attention

🦺 prerequis : commu #864 + itou secrets #118

🦺 Ajouter les variables d'env

🦺 Supprimer les variables d'env

vperron

a part deux nits, dans l'ensemble ça me semble OK. Attention je n'ai pas tenté de lancer l'app ou les tests :)

config/settings/base.py

config/settings/dev.py

github-actions · 2024-12-19T16:56:20Z

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

vincentporte · 2024-12-19T17:03:45Z

check in env var

AWS_STORAGE_BUCKET_NAME 
AWS_STORAGE_BUCKET_NAME_PUBLIC

github-actions · 2024-12-19T17:34:41Z

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

vincentporte · 2024-12-19T17:35:47Z

🔴

2024-12-19T17:34:35.194Z: Loading data
2024-12-19T17:34:36.784Z: Installed 38 object(s) from 1 fixture(s)
2024-12-19T17:34:39.076Z: superuser created
2024-12-19T17:34:39.167Z: Traceback (most recent call last):
2024-12-19T17:34:39.179Z:   File "/home/bas/app_0a1a04d0-6423-4651-b1ca-62d226d8a41a/manage.py", line 31, in <module>
2024-12-19T17:34:39.179Z:     main()
2024-12-19T17:34:39.179Z:     ~~~~^^
2024-12-19T17:34:39.180Z:   File "/home/bas/app_0a1a04d0-6423-4651-b1ca-62d226d8a41a/manage.py", line 27, in main
2024-12-19T17:34:39.180Z:     execute_from_command_line(sys.argv)
2024-12-19T17:34:39.180Z:     ~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^
2024-12-19T17:34:39.180Z:   File "/home/bas/venv/lib/python3.13/site-packages/django/core/management/__init__.py", line 442, in execute_from_command_line
2024-12-19T17:34:39.180Z:     utility.execute()
2024-12-19T17:34:39.180Z:     ~~~~~~~~~~~~~~~^^
2024-12-19T17:34:39.180Z:   File "/home/bas/venv/lib/python3.13/site-packages/django/core/management/__init__.py", line 436, in execute
2024-12-19T17:34:39.180Z:     self.fetch_command(subcommand).run_from_argv(self.argv)
2024-12-19T17:34:39.180Z:     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^
2024-12-19T17:34:39.181Z:   File "/home/bas/venv/lib/python3.13/site-packages/django/core/management/base.py", line 413, in run_from_argv
2024-12-19T17:34:39.181Z:     self.execute(*args, **cmd_options)
2024-12-19T17:34:39.181Z:     ~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.181Z:   File "/home/bas/venv/lib/python3.13/site-packages/django/core/management/base.py", line 459, in execute
2024-12-19T17:34:39.181Z:     output = self.handle(*args, **options)
2024-12-19T17:34:39.181Z:   File "/home/bas/app_0a1a04d0-6423-4651-b1ca-62d226d8a41a/lacommunaute/forum/management/commands/populate.py", line 22, in handle
2024-12-19T17:34:39.181Z:     partners = PartnerFactory.create_batch(5, with_logo=True)
2024-12-19T17:34:39.181Z:   File "/home/bas/venv/lib/python3.13/site-packages/factory/base.py", line 553, in create_batch
2024-12-19T17:34:39.181Z:     return [cls.create(**kwargs) for _ in range(size)]
2024-12-19T17:34:39.181Z:             ~~~~~~~~~~^^^^^^^^^^
2024-12-19T17:34:39.181Z:   File "/home/bas/venv/lib/python3.13/site-packages/factory/base.py", line 539, in create
2024-12-19T17:34:39.181Z:     return cls._generate(enums.CREATE_STRATEGY, kwargs)
2024-12-19T17:34:39.181Z:            ~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.181Z:   File "/home/bas/venv/lib/python3.13/site-packages/factory/django.py", line 122, in _generate
2024-12-19T17:34:39.181Z:     return super()._generate(strategy, params)
2024-12-19T17:34:39.181Z:            ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.181Z:   File "/home/bas/venv/lib/python3.13/site-packages/factory/base.py", line 468, in _generate
2024-12-19T17:34:39.181Z:     return step.build()
2024-12-19T17:34:39.181Z:            ~~~~~~~~~~^^
2024-12-19T17:34:39.181Z:   File "/home/bas/venv/lib/python3.13/site-packages/factory/builder.py", line 274, in build
2024-12-19T17:34:39.181Z:     instance = self.factory_meta.instantiate(
2024-12-19T17:34:39.181Z:         step=step,
2024-12-19T17:34:39.181Z:         args=args,
2024-12-19T17:34:39.181Z:         kwargs=kwargs,
2024-12-19T17:34:39.181Z:     )
2024-12-19T17:34:39.181Z:   File "/home/bas/venv/lib/python3.13/site-packages/factory/base.py", line 320, in instantiate
2024-12-19T17:34:39.181Z:     return self.factory._create(model, *args, **kwargs)
2024-12-19T17:34:39.181Z:            ~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.181Z:   File "/home/bas/venv/lib/python3.13/site-packages/factory/django.py", line 175, in _create
2024-12-19T17:34:39.181Z:     return manager.create(*args, **kwargs)
2024-12-19T17:34:39.181Z:            ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.181Z:   File "/home/bas/venv/lib/python3.13/site-packages/django/db/models/manager.py", line 87, in manager_method
2024-12-19T17:34:39.181Z:     return getattr(self.get_queryset(), name)(*args, **kwargs)
2024-12-19T17:34:39.182Z:     return field.pre_save(obj, add=True)
2024-12-19T17:34:39.182Z:            ~~~~~~~~~~~~~~^^^^^^^^^^^^^^^
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/django/db/models/fields/files.py", line 324, in pre_save
2024-12-19T17:34:39.182Z:     file.save(file.name, file.file, save=False)
2024-12-19T17:34:39.182Z:     ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/django/db/models/fields/files.py", line 94, in save
2024-12-19T17:34:39.182Z:     self.name = self.storage.save(name, content, max_length=self.field.max_length)
2024-12-19T17:34:39.182Z:                 ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/django/core/files/storage/base.py", line 44, in save
2024-12-19T17:34:39.182Z:     name = self.get_available_name(name, max_length=max_length)
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/django/core/files/storage/base.py", line 88, in get_available_name
2024-12-19T17:34:39.182Z:     while self.exists(name) or (max_length and len(name) > max_length):
2024-12-19T17:34:39.182Z:           ~~~~~~~~~~~^^^^^^
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/storages/backends/s3.py", line 587, in exists
2024-12-19T17:34:39.182Z:     self.connection.meta.client.head_object(Bucket=self.bucket_name, Key=name)
2024-12-19T17:34:39.182Z:     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/botocore/client.py", line 569, in _api_call
2024-12-19T17:34:39.182Z:     return self._make_api_call(operation_name, kwargs)
2024-12-19T17:34:39.182Z:            ~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/botocore/client.py", line 964, in _make_api_call
2024-12-19T17:34:39.182Z:     api_params = self._emit_api_params(
2024-12-19T17:34:39.182Z:         api_params=api_params,
2024-12-19T17:34:39.182Z:         operation_model=operation_model,
2024-12-19T17:34:39.182Z:         context=request_context,
2024-12-19T17:34:39.182Z:     )
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/botocore/client.py", line 1083, in _emit_api_params
2024-12-19T17:34:39.182Z:     self.meta.events.emit(
2024-12-19T17:34:39.182Z:     ~~~~~~~~~~~~~~~~~~~~~^
2024-12-19T17:34:39.182Z:         f'before-parameter-build.{service_id}.{operation_name}',
2024-12-19T17:34:39.182Z:         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.182Z:     ...<2 lines>...
2024-12-19T17:34:39.182Z:         context=context,
2024-12-19T17:34:39.182Z:         ^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.182Z:     )
2024-12-19T17:34:39.182Z:     ^
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/botocore/hooks.py", line 412, in emit
2024-12-19T17:34:39.182Z:     return self._emitter.emit(aliased_event_name, **kwargs)
2024-12-19T17:34:39.182Z:            ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/botocore/hooks.py", line 256, in emit
2024-12-19T17:34:39.182Z:     return self._emit(event_name, kwargs)
2024-12-19T17:34:39.182Z:            ~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/botocore/hooks.py", line 239, in _emit
2024-12-19T17:34:39.182Z:     response = handler(**kwargs)
2024-12-19T17:34:39.182Z:   File "/home/bas/venv/lib/python3.13/site-packages/botocore/handlers.py", line 294, in validate_bucket_name
2024-12-19T17:34:39.182Z:     if not VALID_BUCKET.search(bucket) and not VALID_S3_ARN.search(bucket):
2024-12-19T17:34:39.182Z:            ~~~~~~~~~~~~~~~~~~~^^^^^^^^
2024-12-19T17:34:39.182Z: TypeError: expected string or bytes-like object, got 'NoneType'
2024-12-19T17:34:39.630Z: [INFO] Successfully deployed in 1 minute and 19 seconds
2024-12-19T17:34:39.630Z: Uploading application build cache archive… file is 225M before compression.

github-actions · 2025-01-06T08:57:28Z

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

vincentporte · 2025-01-06T09:16:50Z

2025-01-06T08:56:04.808Z: Running CC_PRE_BUILD_HOOK: ./clevercloud/pre_build.sh => 🟢
2025-01-06T08:57:00.179Z: Running CC_PRE_RUN_HOOK: ./clevercloud/pre_run.sh => 🟢

github-actions · 2025-01-06T10:15:45Z

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

## Description 🎸 Isoler les `settings` de test, pour nettoyer les valeurs par défaut des `settings` de base et de dev. 🎸 Utiliser ces `settings` de test pour rendre les tests executables dès le tirage du dépôt. 🎸 Utiliser ces `settings` dans la `CI` pour harmoniser l'execution des tests en local et dans les actions github ## Type de changement 🚧 technique ### Points d'attention 🦺 refactor de l'appel aux settings liés aux envois de mails 🦺 simplification de la gestion des routes `brevo` 🦺 harmonisation des `settings` utilisés pour envoyer le lien magique par mail ou dans les `message` django 🦺 prise en compte des noms de bucket issus des `settings` dans les fichiers de migration 📦 prerequis à la PR #857

github-actions · 2025-01-06T14:59:11Z

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

vincentporte · 2025-01-06T15:03:55Z

🎯 recette jetable 🟢

vincentporte · 2025-01-07T07:04:15Z

Deployement notes :

ENVIRONMENT var must be declared in clevercloud addon, unuseful in base.py
=> commited b98e83f

…ed as env vars in virtual server

vincentporte requested a review from vperron December 11, 2024 15:45

vincentporte self-assigned this Dec 11, 2024

vincentporte added python Pull requests that update Python code technical debt labels Dec 11, 2024

vincentporte changed the title ~~refactor: versionning des variables applicatives~~ refactor: versionning des variables applicatives Dec 11, 2024

vperron reviewed Dec 11, 2024

View reviewed changes

config/settings/base.py Outdated Show resolved Hide resolved

config/settings/dev.py Outdated Show resolved Hide resolved

vperron approved these changes Dec 11, 2024

View reviewed changes

vincentporte force-pushed the vp/init_c3_versionned_env_vars branch 4 times, most recently from 66d1631 to a32a2f5 Compare December 19, 2024 09:59

vincentporte mentioned this pull request Dec 19, 2024

refactor: isoler les settings de test #864

Merged

vincentporte force-pushed the vp/init_c3_versionned_env_vars branch 2 times, most recently from 1b874c4 to 10cf3d1 Compare December 19, 2024 16:18

vincentporte added the recette-jetable review_app label Dec 19, 2024

vincentporte changed the base branch from master to vp/isolate_test_conf December 19, 2024 16:43

vincentporte added recette-jetable review_app and removed recette-jetable review_app labels Dec 19, 2024

vincentporte removed the recette-jetable review_app label Dec 19, 2024

vincentporte added the recette-jetable review_app label Jan 6, 2025

vincentporte removed the recette-jetable review_app label Jan 6, 2025

vincentporte force-pushed the vp/init_c3_versionned_env_vars branch from 319264e to 9b7ad67 Compare January 6, 2025 10:07

vincentporte added the recette-jetable review_app label Jan 6, 2025

Base automatically changed from vp/isolate_test_conf to master January 6, 2025 10:20

vincentporte removed the recette-jetable review_app label Jan 6, 2025

vincentporte force-pushed the vp/init_c3_versionned_env_vars branch from 9b7ad67 to fa53d57 Compare January 6, 2025 14:41

vincentporte added 4 commits January 6, 2025 15:44

set ENVIRONMENT var in review app

5583303

set dynamic ENVIRONMENT collection in base.py

45a2fc2

add script to collect env vars from repo

f51b544

make pre_*.sh executable

18549bd

vincentporte force-pushed the vp/init_c3_versionned_env_vars branch from fa53d57 to 18549bd Compare January 6, 2025 14:44

vincentporte added recette-jetable review_app and removed recette-jetable review_app labels Jan 6, 2025

vincentporte marked this pull request as ready for review January 6, 2025 15:03

vincentporte removed the recette-jetable review_app label Jan 6, 2025

francoisfreitag approved these changes Jan 7, 2025

View reviewed changes

remove default value for ENVIRONMENT in base.py because it must defin…

b98e83f

…ed as env vars in virtual server

vincentporte merged commit d048878 into master Jan 7, 2025
11 checks passed

vincentporte deleted the vp/init_c3_versionned_env_vars branch January 7, 2025 07:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: versionning des variables applicatives #857

refactor: versionning des variables applicatives #857

vincentporte commented Dec 11, 2024 •

edited

Loading

vperron left a comment

github-actions bot commented Dec 19, 2024

vincentporte commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

vincentporte commented Dec 19, 2024

github-actions bot commented Jan 6, 2025

vincentporte commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

vincentporte commented Jan 6, 2025

vincentporte commented Jan 7, 2025 •

edited

Loading

refactor: versionning des variables applicatives #857

refactor: versionning des variables applicatives #857

Conversation

vincentporte commented Dec 11, 2024 • edited Loading

Description

Type de changement

Points d'attention

🦺 Ajouter les variables d'env

🦺 Supprimer les variables d'env

vperron left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 19, 2024

vincentporte commented Dec 19, 2024

github-actions bot commented Dec 19, 2024

vincentporte commented Dec 19, 2024

github-actions bot commented Jan 6, 2025

vincentporte commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

github-actions bot commented Jan 6, 2025

vincentporte commented Jan 6, 2025

vincentporte commented Jan 7, 2025 • edited Loading

vincentporte commented Dec 11, 2024 •

edited

Loading

vincentporte commented Jan 7, 2025 •

edited

Loading