-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(forum_conversation): filtrer les questions dans l'espace d'échanges #681
Merged
vincentporte
merged 7 commits into
master
from
679-forumconversation-poser-une-question
Jun 24, 2024
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8e2e66e
fix is_in_documentation_area method, 'self.get_ancestors().first().ty…
vincentporte e2db2c4
forum_conversation: remove emplois_helpdesk banner
vincentporte 4fae037
forum_conversation: remove deadcode in topic_create template
vincentporte 18a8b02
forum_conversation: add topic_create_check view
vincentporte 770dcb7
forum_conversation: redirect to topic_create_check view on conditions…
vincentporte e8cb484
forum_conversation: update TopicCreateView tests
vincentporte 26f58d5
get better template
vincentporte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,7 +2,9 @@ | |
|
||
from django.conf import settings | ||
from django.contrib import messages | ||
from django.shortcuts import get_object_or_404, redirect, render | ||
from django.urls import reverse | ||
from django.views import View | ||
from django.views.generic import ListView | ||
from machina.apps.forum_conversation import views | ||
from machina.core.loading import get_class | ||
|
@@ -30,9 +32,26 @@ def form_valid(self, *args, **kwargs): | |
return valid | ||
|
||
|
||
class TopicCreateCheckView(View): | ||
def get(self, request, *args, **kwargs): | ||
forum = get_object_or_404(Forum, pk=kwargs["forum_pk"]) | ||
return render(request, "forum_conversation/topic_create_check.html", {"forum": forum}) | ||
|
||
|
||
class TopicCreateView(FormValidMixin, views.TopicCreateView): | ||
post_form_class = TopicForm | ||
|
||
def get(self, request, *args, **kwargs): | ||
forum = self.get_forum() | ||
if forum.is_in_documentation_area or self.request.GET.get("checked"): | ||
return super().get(request, *args, **kwargs) | ||
return redirect( | ||
reverse( | ||
"forum_conversation_extension:topic_create_check", | ||
kwargs={"forum_pk": forum.pk, "forum_slug": forum.slug}, | ||
) | ||
) | ||
Comment on lines
+44
to
+53
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Efficace :) |
||
|
||
def get_success_url(self): | ||
if not self.forum_post.approved: | ||
return reverse( | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK!