Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ajout de minio comme bucket S3 (dev & test) #633

Merged
merged 11 commits into from
May 27, 2024

Conversation

vincentporte
Copy link
Contributor

@vincentporte vincentporte commented May 22, 2024

Description

🎸 Ajout de Minio pour les tests mettant en oeuvre le bucket S3 dans la CI
🎸 Plusieurs correctifs pour utiliser le bucket clever c3-django-review-s3 avec les recettes jetables

Type de changement

🎨 changement nécessitant une mise à jour de la documentation.
🚧 technique

Points d'attention

🦺 mise à jour de CLEVER_REVIEW_APPS_S3_ADDON dans les secrets GH
🦺 amélioration de la generation des mots de passe dans UserFactory
🦺 correction du script populate pour les besoins de la recette jetable
🦺 mise à jour des variables d'environnement CELLAR_ADDON_KEY_ID CELLAR_ADDON_KEY_SECRET CELLAR_ADDON_HOST et CELLAR_ADDON_PROTOCOL dans base.pypour gérer la compatibilité avec minio en local

⚠️ pre-requis pour la #632

@vincentporte vincentporte self-assigned this May 22, 2024
@vincentporte vincentporte added recette-jetable review_app python Pull requests that update Python code labels May 23, 2024
Copy link
Contributor

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@vincentporte
Copy link
Contributor Author

/!\ ajouter la commande configure_bucket dans la CI

Copy link
Contributor

@francoisfreitag francoisfreitag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Il faudra penser à ajouter configure_bucket dans les managements command au déploiement côté clever.

docker-compose.yml Show resolved Hide resolved
lacommunaute/forum/management/commands/populate.py Outdated Show resolved Hide resolved
@vincentporte vincentporte removed the recette-jetable review_app label May 23, 2024
@vincentporte vincentporte added the recette-jetable review_app label May 23, 2024
Copy link
Contributor

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@vincentporte vincentporte removed the recette-jetable review_app label May 23, 2024
@vincentporte vincentporte added the recette-jetable review_app label May 23, 2024
Copy link
Contributor

🥁 La recette jetable est prête ! 👉 Je veux tester cette PR !

@vincentporte vincentporte merged commit d9e1fd1 into master May 27, 2024
5 of 7 checks passed
@vincentporte vincentporte deleted the vp/setup_minio_s3 branch May 27, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VALIDATION] attribuer les droits de staff et de superuser à l'utilisateur de base
2 participants