Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(pipeline): send raw context to webhook #354

Closed
wants to merge 1 commit into from

Conversation

vmttn
Copy link
Contributor

@vmttn vmttn commented Dec 16, 2024

We will introduce a broker to dispatch webhooks the right place. Doing so, we'll be able to filter events to remove duplicates and prevent flooding the alerting channel.

Also, the scheduler does not have to send messages that comply to mattermost and therefore can be decoupled from the mattermost interface : we just send the context data somewhere.

  • change the webhook in the configuration

We will introduce a broker to dispatch webhooks
to the right place. Doing so, we'll be able to
filter events and prevent flooding the alerting
channel.

Also, the scheduler does not have to send messages
that comply to mattermost and therefore can be
decoupled from the mattermost interface.
Copy link
Contributor

@vperron vperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Je comprends bien l'intention, maintenant j'attends de voir ce qu'on choisit comme broker :) Est-ce qu'on code un petit truc ou non, etc.

Et sinon, peut etre séparément, investiguer la configuration Sentry ? https://airflow.apache.org/docs/apache-airflow/stable/administration-and-deployment/logging-monitoring/errors.html

Sachant que derrière, Sentry peut aussi envoyer des notifs Slack ou Mattermost, en évitant le spam. Mais je n'insiste pas trop, on pourra investiguer le sujet séparément of course.

@vmttn
Copy link
Contributor Author

vmttn commented Dec 20, 2024

oui je suis ok pour regarder du côté de sentry :)

j'ai un truc fonctionnel avec n8n en broker. Franchement ça pourrait être zapier.

image

J'ai un doute sur le fait que le n8n soit bien maintenu (la version a un peu de retard) ET j'ai l'impression que la gestion d'accès au workflow va demander un compte de service ?
image

@vperron
Copy link
Contributor

vperron commented Jan 13, 2025

Jérémy a fait une grosse MAJ de N8N hier, et pour le compte de service en effet, ça y ressemble mais je pense qu'il faut lui poser la question, je ne sais pas ce qu'ils ont décidé en pareil cas.

@vmttn vmttn closed this Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants