Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macos support #32

Closed
wants to merge 6 commits into from
Closed

Macos support #32

wants to merge 6 commits into from

Conversation

bjorn3
Copy link
Contributor

@bjorn3 bjorn3 commented Apr 27, 2019

Based on #29, #30 and #31.

Fixes #2

I did something wrong causing it to not find the FDE for an address, but I dont know what.

bjorn3
bjorn3 commented Apr 27, 2019
View reviewed changes
unwind/src/unwind_helper.c
@@ -1,4 +1,3 @@

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This really broke using nanoas editor.

bjorn3
bjorn3 commented Apr 27, 2019
View reviewed changes
unwind/src/lib.rs
}

fde = eh_frame.fde_for_address(bases, address, EhFrame::cie_from_offset).unwrap();
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails here

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works on linux (after I hack it to use EhRef::WithoutHeader for linux too).

@philipc
Copy link
Contributor

philipc commented Apr 28, 2019

While it should be possible to get it to work without, I think you should try to use eh_frame_hdr on macos. Some work on that was started here.

@bjorn3
Copy link
Contributor Author

bjorn3 commented Apr 28, 2019

.eh_frame_hdr doesnt seem to exist on macOS.

Some work on that was started here.

It would be nice to have that commit on master, as it allows getting .eh_frame on macOS without having to copy and leak it and without having to deal with fat libraries.

@philipc
Copy link
Contributor

philipc commented Apr 28, 2019

That commit is lacking linux support, so merging it to master is non-trivial. Any work on it is appreciated. Be aware that the EhFrame trait will be hard to implement for linux since the section headers aren't available AFAIK.

@bjorn3
Copy link
Contributor Author

bjorn3 commented Jan 23, 2021

I won't work any further on this.

@bjorn3 bjorn3 closed this Jan 23, 2021
@bjorn3 bjorn3 deleted the macos branch January 23, 2021 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipc philipc philipc left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OSX support
2 participants
@bjorn3 @philipc