Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CircleCI configuration for pushing to container registries #43

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

marians
Copy link
Member

@marians marians commented Nov 29, 2023

Towards giantswarm/roadmap#2979

Context: announcement in #news-dev on Slack

This PR was created through automation by Team Honeybadger, to make sure that the container images built for this repository are available in the right registries.

For that, the CircleCI configuration is modified to use the new push-to-registries job instead of the old push-to-docker. This means that there is only one job for all registry pushes, and it simplifies the configuration by removing many parameters that are now set automatically or as defaults.

Notes

  • Since the PR is also changing the CircleCI job name to push-to-registries, the branch protection rules in this repository will likely require updating before the required checks can be green.
  • Dev images are sent to ACR (gsoci.azurecr.io) and Quay currently. If you need dev images elsewhere, you can add the according configuration as described in the documentation to the step configuration.

To the responsible team

Please,

  • Assign this PR to yourself
  • Verify that the check ci/circleci: push-to-registries has been executed successfully.
  • Double-check the job dependecies (requires)
  • Double-check the job filters. Especially if this PR replaces several jobs with one, and the previous jobs had different filters, make sure that the filter includes all cases.
  • Update the changelog if you think this deserves a mention
  • Approve and merge this PR once it's ready. No need to wait for the author in this case.

Please get this done until December 5, so that we can move on with the next migration steps. Thank you!

@marians marians requested a review from a team as a code owner November 29, 2023 14:44
@marians
Copy link
Member Author

marians commented Nov 29, 2023

FYI There seem to be no required PR checks in this repo (branch protection rules)

@anvddriesch anvddriesch merged commit 0757300 into main Dec 5, 2023
5 checks passed
@anvddriesch anvddriesch deleted the circleci-image-registry-configuration branch December 5, 2023 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants