Teleport Matchine ID & Tests #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvondruska
commented
Nov 16, 2023
| os.Exit(1) | ||
| } | ||
| setupLog.Info("Connected to teleport cluster", "proxyAddr", tele.SecretConfig.ProxyAddr) | ||
|
|
There was a problem hiding this comment.
Teleport client requires an identity file. However, when the operator starts, the identity may not be available yet, because it's provided by an external resource (tbot).
So, it is not safe to instantiate the client when the operator starts, because it would cause a crash in case the identity is not available.
Therefore, the creation of Teleport client was moved to reconciliation..
vvondruska
commented
Nov 16, 2023
| @@ -19,7 +19,7 @@ type Client interface { | |||
| DeleteToken(ctx context.Context, name string) error | |||
| } | |||
|
|
|||
| func NewClient(ctx context.Context, proxyAddr, identityFile string) (Client, error) { | |||
| var NewClient = func(ctx context.Context, proxyAddr, identityFile string) (Client, error) { | |||
There was a problem hiding this comment.
Changed this to a variable, so that it can be replaced with a mock in tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Made some adjustments in the code to add support for additional tests
Migrated main operator configuration from secret to config map
Added tests of Teleport machine ID renewal
Checklist