Skip to content

Commit

Permalink
Revert "Use proxy_from_environment in Alertmanager (#1782)" (#1792)
Browse files Browse the repository at this point in the history
This reverts commit 3f42eba.
  • Loading branch information
TheoBrigitte authored Jan 6, 2025
1 parent 8fc99d6 commit 555f112
Show file tree
Hide file tree
Showing 26 changed files with 46 additions and 436 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Changed

- Revert `proxy_from_environment: true`, as this is only compatible with observability-bundle >= v1.8.0.

## [4.84.0] - 2025-01-06

### Changed
Expand Down
62 changes: 42 additions & 20 deletions files/templates/alertmanager/alertmanager.yaml
Original file line number Diff line number Diff line change
@@ -1,7 +1,9 @@
global:
resolve_timeout: 5m
[[- if .ProxyURL ]]
http_config:
proxy_from_environment: true
proxy_url: [[ .ProxyURL ]]
[[- end ]]
[[- if .SlackApiToken ]]
slack_api_url: "https://slack.com/api/chat.postMessage"
[[- else ]]
Expand Down Expand Up @@ -178,7 +180,9 @@ receivers:
credentials: [[ .OpsgenieKey ]]
follow_redirects: true
enable_http2: true
proxy_from_environment: true
[[- if .ProxyURL ]]
proxy_url: [[ .ProxyURL ]]
[[- end ]]
url: https://api.opsgenie.com/v2/heartbeats/[[ .Installation ]]/ping
[[- end ]]

Expand All @@ -189,13 +193,15 @@ receivers:
- name: falco_noise_slack
slack_configs:
- channel: '#noise-falco'
[[- if .SlackApiToken ]]
http_config:
[[- if .SlackApiToken ]]
authorization:
type: Bearer
credentials: [[ .SlackApiToken ]]
[[- if .ProxyURL ]]
proxy_url: [[ .ProxyURL ]]
[[- end ]]
proxy_from_environment: true
[[- end ]]
send_resolved: true
actions:
- type: button
Expand Down Expand Up @@ -223,13 +229,15 @@ receivers:
[[- else ]]
- channel: '#alert-atlas-test'
[[- end ]]
[[- if .SlackApiToken ]]
http_config:
[[- if .SlackApiToken ]]
authorization:
type: Bearer
credentials: [[ .SlackApiToken ]]
[[- if .ProxyURL ]]
proxy_url: [[ .ProxyURL ]]
[[- end ]]
proxy_from_environment: true
[[- end ]]
send_resolved: true
actions:
- type: button
Expand Down Expand Up @@ -257,13 +265,15 @@ receivers:
[[- else ]]
- channel: '#alert-phoenix-test'
[[- end ]]
[[- if .SlackApiToken ]]
http_config:
[[- if .SlackApiToken ]]
authorization:
type: Bearer
credentials: [[ .SlackApiToken ]]
[[- if .ProxyURL ]]
proxy_url: [[ .ProxyURL ]]
[[- end ]]
proxy_from_environment: true
[[- end ]]
send_resolved: true
actions:
- type: button
Expand Down Expand Up @@ -291,13 +301,15 @@ receivers:
[[- else ]]
- channel: '#alert-bigmac-test'
[[- end ]]
[[- if .SlackApiToken ]]
http_config:
[[- if .SlackApiToken ]]
authorization:
type: Bearer
credentials: [[ .SlackApiToken ]]
[[- if .ProxyURL ]]
proxy_url: [[ .ProxyURL ]]
[[- end ]]
proxy_from_environment: true
[[- end ]]
send_resolved: true
actions:
- type: button
Expand Down Expand Up @@ -325,13 +337,15 @@ receivers:
[[- else ]]
- channel: '#alert-rocket-test'
[[- end ]]
[[- if .SlackApiToken ]]
http_config:
[[- if .SlackApiToken ]]
authorization:
type: Bearer
credentials: [[ .SlackApiToken ]]
[[- if .ProxyURL ]]
proxy_url: [[ .ProxyURL ]]
[[- end ]]
proxy_from_environment: true
[[- end ]]
send_resolved: true
actions:
- type: button
Expand All @@ -355,13 +369,15 @@ receivers:
- name: team_shield_slack
slack_configs:
- channel: '#alert-shield'
[[- if .SlackApiToken ]]
http_config:
[[- if .SlackApiToken ]]
authorization:
type: Bearer
credentials: [[ .SlackApiToken ]]
[[- if .ProxyURL ]]
proxy_url: [[ .ProxyURL ]]
[[- end ]]
proxy_from_environment: true
[[- end ]]
send_resolved: true
actions:
- type: button
Expand Down Expand Up @@ -389,13 +405,15 @@ receivers:
[[- else ]]
- channel: '#alert-turtles-test'
[[- end ]]
[[- if .SlackApiToken ]]
http_config:
[[- if .SlackApiToken ]]
authorization:
type: Bearer
credentials: [[ .SlackApiToken ]]
[[- if .ProxyURL ]]
proxy_url: [[ .ProxyURL ]]
[[- end ]]
proxy_from_environment: true
[[- end ]]
send_resolved: true
actions:
- type: button
Expand All @@ -419,13 +437,15 @@ receivers:
- name: team_tenet_slack
slack_configs:
- channel: '#alert-tenet'
[[- if .SlackApiToken ]]
http_config:
[[- if .SlackApiToken ]]
authorization:
type: Bearer
credentials: [[ .SlackApiToken ]]
[[- if .ProxyURL ]]
proxy_url: [[ .ProxyURL ]]
[[- end ]]
proxy_from_environment: true
[[- end ]]
send_resolved: true
actions:
- type: button
Expand All @@ -449,13 +469,15 @@ receivers:
- name: team_honeybadger_slack
slack_configs:
- channel: '#alert-honeybadger'
[[- if .SlackApiToken ]]
http_config:
[[- if .SlackApiToken ]]
authorization:
type: Bearer
credentials: [[ .SlackApiToken ]]
[[- if .ProxyURL ]]
proxy_url: [[ .ProxyURL ]]
[[- end ]]
proxy_from_environment: true
[[- end ]]
send_resolved: true
actions:
- type: button
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
global:
resolve_timeout: 5m
http_config:
proxy_from_environment: true
slack_api_url: https://slack

templates:
Expand Down Expand Up @@ -118,8 +116,6 @@ receivers:
- name: falco_noise_slack
slack_configs:
- channel: '#noise-falco'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -143,8 +139,6 @@ receivers:
- name: team_atlas_slack
slack_configs:
- channel: '#alert-atlas-test'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -168,8 +162,6 @@ receivers:
- name: team_phoenix_slack
slack_configs:
- channel: '#alert-phoenix-test'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -193,8 +185,6 @@ receivers:
- name: team_bigmac_slack
slack_configs:
- channel: '#alert-bigmac-test'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -218,8 +208,6 @@ receivers:
- name: team_rocket_slack
slack_configs:
- channel: '#alert-rocket-test'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -243,8 +231,6 @@ receivers:
- name: team_shield_slack
slack_configs:
- channel: '#alert-shield'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -268,8 +254,6 @@ receivers:
- name: team_turtles_slack
slack_configs:
- channel: '#alert-turtles-test'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -293,8 +277,6 @@ receivers:
- name: team_tenet_slack
slack_configs:
- channel: '#alert-tenet'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -318,8 +300,6 @@ receivers:
- name: team_honeybadger_slack
slack_configs:
- channel: '#alert-honeybadger'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
global:
resolve_timeout: 5m
http_config:
proxy_from_environment: true
slack_api_url: https://slack

templates:
Expand Down Expand Up @@ -118,8 +116,6 @@ receivers:
- name: falco_noise_slack
slack_configs:
- channel: '#noise-falco'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -143,8 +139,6 @@ receivers:
- name: team_atlas_slack
slack_configs:
- channel: '#alert-atlas-test'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -168,8 +162,6 @@ receivers:
- name: team_phoenix_slack
slack_configs:
- channel: '#alert-phoenix-test'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -193,8 +185,6 @@ receivers:
- name: team_bigmac_slack
slack_configs:
- channel: '#alert-bigmac-test'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -218,8 +208,6 @@ receivers:
- name: team_rocket_slack
slack_configs:
- channel: '#alert-rocket-test'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -243,8 +231,6 @@ receivers:
- name: team_shield_slack
slack_configs:
- channel: '#alert-shield'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -268,8 +254,6 @@ receivers:
- name: team_turtles_slack
slack_configs:
- channel: '#alert-turtles-test'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -293,8 +277,6 @@ receivers:
- name: team_tenet_slack
slack_configs:
- channel: '#alert-tenet'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand All @@ -318,8 +300,6 @@ receivers:
- name: team_honeybadger_slack
slack_configs:
- channel: '#alert-honeybadger'
http_config:
proxy_from_environment: true
send_resolved: true
actions:
- type: button
Expand Down
Loading

0 comments on commit 555f112

Please sign in to comment.