Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the default GitHub connector config to include
teamNameField: slug
.See the dex docs for details.
As the only team we are currently using is
giantswarm-admins
, whose name and slug are equal, this won't have any effect.Towards giantswarm/roadmap#1205
Note
I've also changed the yaml marshalling. The config is converted to JSON first, so that the
json
annotations on the config struct are actually used and not just a lower-case representation of the key's name.before:
after: