Update CircleCI configuration for pushing to container registries (#100)

* Add CircleCI image registry configuration * Mitigate implicit memory aliasing in for loop
giantswarm · Nov 30, 2023 · 2c71b73 · 2c71b73
1 parent 688d4fb
commit 2c71b73
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 38 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -1,7 +1,7 @@
 version: 2.1
 
 orbs:
-  architect: giantswarm/architect@4.33.0
+  architect: giantswarm/architect@4.35.5
 
 jobs:
   tests:
@@ -27,56 +27,23 @@ workflows:
           filters:
             tags:
               only: /^v.*/
-      - architect/push-to-docker:
+      - architect/push-to-registries:
           context: architect
-          name: push-dex-operator-to-quay
-          image: "quay.io/giantswarm/dex-operator"
-          username_envar: "QUAY_USERNAME"
-          password_envar: "QUAY_PASSWORD"
-          resource_class: xlarge
+          name: push-to-registries
           requires:
             - go-build
           filters:
             # Trigger the job also on git tag.
             tags:
               only: /^v.*/
-      - architect/push-to-docker:
-          context: "architect"
-          name: push-dex-operator-to-docker
-          image: "docker.io/giantswarm/dex-operator"
-          username_envar: "DOCKER_USERNAME"
-          password_envar: "DOCKER_PASSWORD"
-          resource_class: xlarge
-          requires:
-            - go-build
-          # Needed to trigger job also on git tag.
-          filters:
-            tags:
-              only: /^v.*/
-      - architect/push-to-docker:
-          context: architect
-          name: push-dex-operator-to-aliyun
-          image: "giantswarm-registry.cn-shanghai.cr.aliyuncs.com/giantswarm/dex-operator"
-          username_envar: "ALIYUN_USERNAME"
-          password_envar: "ALIYUN_PASSWORD"
-          resource_class: xlarge
-          requires:
-            - go-build
-          # Needed to trigger job also on git tag.
-          filters:
-            tags:
-              only: /^v.*/
-      # Ensure that for every commit
-      # there is an app version in the test catalog.
       - architect/push-to-app-catalog:
           context: architect
           name: push-to-app-catalog
           app_catalog: "control-plane-catalog"
           app_catalog_test: "control-plane-test-catalog"
           chart: "dex-operator"
           requires:
-            - push-dex-operator-to-quay
-            - push-dex-operator-to-docker
+            - push-to-registries
           filters:
             # Trigger the job also on git tag.
             tags:

diff --git a/pkg/idp/provider/azure/azure_test.go b/pkg/idp/provider/azure/azure_test.go
@@ -252,7 +252,7 @@ func TestSecretExpired(t *testing.T) {
 	for i, tc := range testCases {
 		t.Run(strconv.Itoa(i), func(t *testing.T) {
 			s := models.NewPasswordCredential()
-			s.SetEndDateTime(&tc.expirationDate)
+			s.SetEndDateTime(&testCases[i].expirationDate)
 			if secretExpired(s) != tc.expired {
 				t.Fatalf("Expected %v, got %v", tc.expired, secretExpired(s))
 			}