Restrict .providerSpecific.location value to enum
#144
Conversation
marians
changed the title
.providerSpecific.location value to enum.providerSpecific.location value to enum
|
/run cluster-test-suites |
helm/cluster-azure/README.md
Outdated
| @@ -102,6 +102,8 @@ Properties within the `.metadata` top-level object | |||
| | **Property** | **Description** | **More Details** | | |||
| | :----------- | :-------------- | :--------------- | | |||
| | `metadata.description` | **Cluster description** - User-friendly description of the cluster's purpose.|**Type:** `string`<br/>| | |||
| | `metadata.labels` | **Labels** - These labels are added to the Kubernetes resourses defining this cluster.|**Type:** `object`<br/>| | |||
There was a problem hiding this comment.
I believe this is unrelated to the PR.
There was a problem hiding this comment.
True. I just updated the docs automatically, and this was added, too.
| @@ -514,6 +514,14 @@ | |||
| "location": { | |||
| "type": "string", | |||
| "title": "Location", | |||
| "$comment": "Valid options from https://github.com/giantswarm/capi-image-builder/blob/v1.6.10/helm/capi-image-builder/values.yaml#L48-L52", | |||
There was a problem hiding this comment.
Can you maybe add a comment in that capi-image-builder file regarding updating cluster-azure when adding a new region?
There was a problem hiding this comment.
All right, added a draft PR here. https://github.com/giantswarm/capi-image-builder/pull/91
|
@fiunchinho Heimdall is the last thing pending here. How does this work? Do I wait until that's green? |
|
|
|
/run cluster-test-suites |
Towards giantswarm/roadmap#2573
To avoid bad values (especially unsupported regions), this PR restricts the location value to a set of defined values, taken from https://github.com/giantswarm/capi-image-builder/blob/v1.6.10/helm/capi-image-builder/values.yaml#L48-L52
This also means that when the list in
capi-image-buildergets changed, it should be changed here accordingly.Please check if PR meets these requirements
Helper
/no_diffs_printingon the PR.Trigger e2e tests
/run cluster-test-suites