Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ingress and egress rules from VPC default security group #466

Merged
merged 4 commits into from
Feb 1, 2024

Conversation

fiunchinho
Copy link
Member

What this PR does / why we need it

Towards giantswarm/roadmap#3015

Checklist

  • Update changelog in CHANGELOG.md.

@fiunchinho fiunchinho self-assigned this Dec 21, 2023
@fiunchinho fiunchinho force-pushed the secure-default-vpc-sg branch from ed649c9 to 5dd2d68 Compare January 23, 2024 15:19
@fiunchinho fiunchinho marked this pull request as ready for review January 23, 2024 15:19
@fiunchinho fiunchinho requested a review from a team as a code owner January 23, 2024 15:19
@fiunchinho fiunchinho force-pushed the secure-default-vpc-sg branch from 5dd2d68 to ed9eb01 Compare January 23, 2024 15:21
@fiunchinho fiunchinho force-pushed the secure-default-vpc-sg branch from ed9eb01 to cc8ae87 Compare January 23, 2024 15:22
@AndiDog
Copy link
Contributor

AndiDog commented Jan 31, 2024

/run cluster-test-suites

@tinkerers-ci
Copy link

tinkerers-ci bot commented Jan 31, 2024

cluster-test-suites

Run name pr-cluster-aws-466-cluster-test-suitesbg6wn
Commit SHA 05d7a2b
Result Succeeded ✅

📋 View full results in Tekton Dashboard

Rerun trigger:
/run cluster-test-suites

Copy link
Contributor

github-actions bot commented Feb 1, 2024

(helm/cluster-aws/ci/test-network-topology-values.yaml) rendered manifest diff
/spec/network/vpc  (AWSCluster/org-giantswarm/test-wc-minimal)
  + one map entry added:
    emptyRoutesDefaultVPCSecurityGroup: true

Copy link
Contributor

github-actions bot commented Feb 1, 2024

(helm/cluster-aws/ci/test-mc-proxy-values.yaml) rendered manifest diff
/spec/network/vpc  (AWSCluster/org-giantswarm/test-mc-proxy)
  + one map entry added:
    emptyRoutesDefaultVPCSecurityGroup: true

Copy link
Contributor

github-actions bot commented Feb 1, 2024

(helm/cluster-aws/ci/test-wc-minimal-values.yaml) rendered manifest diff
/spec/network/vpc  (AWSCluster/org-giantswarm/test-wc-minimal)
  + one map entry added:
    emptyRoutesDefaultVPCSecurityGroup: true

@AndiDog AndiDog merged commit 2617e47 into master Feb 1, 2024
13 of 14 checks passed
@AndiDog AndiDog deleted the secure-default-vpc-sg branch February 1, 2024 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants