Try deleting machine pool user data file from S3 when pruning an old launch template version, add S3 storage tests (port to release-2.4) #606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #601 and the test fix #605 to our
release-2.4branch.I first thought this would become more complex due to Ignition-related upstream changes, but the choice
IgnitionStorageTypeOptionClusterObjectStore/IgnitionStorageTypeOptionUnencryptedUserDataisn't supported yet for machine pools, so it looks like we can simply forward-port my changes as such.For review, maybe it helps to compare this diff against the original PR's diff, since those should almost be equal.