Skip to content

✨ feat: custom lifecyclehooks for machinepools #41

✨ feat: custom lifecyclehooks for machinepools

✨ feat: custom lifecyclehooks for machinepools #41

Triggered via pull request November 27, 2024 15:08
Status Failure
Total duration 3m 29s
Artifacts

pr-golangci-lint.yaml

on: pull_request
Matrix: lint
Fit to window
Zoom out
Zoom in

Annotations

9 errors
lint: pkg/cloud/services/autoscaling/autoscalinggroup_test.go#L1183
indent-error-flow: if block ends with a return statement, so drop this else and outdent its block (revive)
lint: pkg/cloud/services/autoscaling/lifecyclehook.go#L133
`getLifecycleHookSpecificationList` - result `ret` is always `nil` (unparam)
lint: pkg/cloud/services/s3/s3.go#L540
appendCombine: can combine chain of 2 appends into one (gocritic)
lint: pkg/cloud/services/s3/s3.go#L222
exported: exported method Service.CreateForMachinePool should have comment or be unexported (revive)
lint: pkg/cloud/services/s3/s3.go#L339
exported: exported method Service.DeleteForMachinePool should have comment or be unexported (revive)
lint: pkg/cloud/services/ec2/launchtemplate_test.go#L88
appendCombine: can combine chain of 2 appends into one (gocritic)
lint: exp/controllers/awsmachinepool_controller.go#L421
declaration has 3 blank identifiers (dogsled)
lint: exp/controllers/awsmanagedmachinepool_controller.go#L224
var-declaration: should drop = nil from declaration of var objectStoreSvc; it is the zero value (revive)
lint
issues found