Skip to content

Commit

Permalink
Fix China bucket name (#313)
Browse files Browse the repository at this point in the history
* irsafixchina

* Update CHANGELOG.md
  • Loading branch information
paurosello authored Jul 11, 2024
1 parent a1b0325 commit 7393a27
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Fixed

- IRSA bucket versioning on CAPA is "v3"

## [0.26.0] - 2024-07-09

### Changed
Expand Down
2 changes: 1 addition & 1 deletion pkg/key/key.go
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ func IsBastionAWSMachineTemplate(labels map[string]string) bool {

func IRSADomain(baseDomain string, region string, awsAccount string, clusterName string) string {
if IsChinaRegion(region) {
return fmt.Sprintf("s3.%s.amazonaws.com.cn/%s-g8s-%s-oidc-pod-identity-v2", region, awsAccount, clusterName)
return fmt.Sprintf("s3.%s.amazonaws.com.cn/%s-g8s-%s-oidc-pod-identity-v3", region, awsAccount, clusterName)
} else {
return fmt.Sprintf("irsa.%s", baseDomain)
}
Expand Down

0 comments on commit 7393a27

Please sign in to comment.